Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError by explictly calling shadowed builtins.type #762

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix TypeError by explictly calling shadowed builtins.type #762

merged 1 commit into from
Jan 4, 2024

Conversation

aazuspan
Copy link
Contributor

@aazuspan aazuspan commented Jan 4, 2024

Closes #761 by explicitly calling builtins.type instead of the type argument that's shadowing it.

dberenbaum
dberenbaum approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aazuspan!

@dberenbaum dberenbaum merged commit 5c650ef into iterative:main Jan 4, 2024
10 of 11 checks passed
@aazuspan aazuspan deleted the fix-type-error branch January 4, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid path causes TypeError due to shadowed builtin type
2 participants
@aazuspan @dberenbaum